pnowojski commented on a change in pull request #9564: 
[FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox 
for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r319478576
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/AbstractInvokable.java
 ##########
 @@ -261,10 +261,9 @@ public void abortCheckpointOnBarrier(long checkpointId, 
Throwable cause) throws
         * Invoked when a checkpoint has been completed, i.e., when the 
checkpoint coordinator has received
 
 Review comment:
   > [FLINK-12482][runtime] Move CheckpointListener.notifyCheckpointComplete 
call into StreamTask
   
   Why did we need this change? Can you explain the reason behind this commit 
inside the commit message?
   
   Maybe it should be squashed with the following commit?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to