[ 
https://issues.apache.org/jira/browse/FLINK-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943647#comment-14943647
 ] 

ASF GitHub Bot commented on FLINK-2793:
---------------------------------------

Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1202#issuecomment-145598003
  
    The PR looks good. I think we cannot do much about it being a temporary 
workaround for the limitation that our `ExecutionGraph` is not serializable. 
Once we have the resources this should be addressed, though.
    
    I've got some minor comments. The main point is the blocking call in the 
`notifyLeaderAddress` of the `JobManagerArchiverRetriever`. This should be 
fixed imo.
    
    Moreover, I think I've found a race condition. The `RuntimeMonitorHandler` 
checks whether the current leader is its own or a remote one. If it's the local 
JM, then the respective RequestHandler is called. Within the `RequestHandler`, 
such as `CurrentJobsOverviewHandler` the `JobManagerArchiverRetriever` is 
called again. If now the leader has changed to be a remote JM, then we'll have 
a problem. This could be fixed as well.


> Redirect to leading JobManager web fronted in non-standalone mode
> -----------------------------------------------------------------
>
>                 Key: FLINK-2793
>                 URL: https://issues.apache.org/jira/browse/FLINK-2793
>             Project: Flink
>          Issue Type: Improvement
>          Components: JobManager
>    Affects Versions: master
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>
> In case of a non-standalone recovery mode, the job manager frontend of 
> non-leading job managers prints the job manager information of its associated 
> job manager. Because the job manager is not leading, nothing shows up.
> The web frontend cannot directly communicate with the leading job manager, 
> because many job manager structures like the execution graph are not 
> serializable.
> A work around is to redirect to the web frontend of the leading job manager. 
> This makes sure that all interesting information is presented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to