[ 
https://issues.apache.org/jira/browse/FLINK-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945123#comment-14945123
 ] 

ASF GitHub Bot commented on FLINK-2793:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1202#discussion_r41272418
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
 ---
    @@ -150,97 +148,97 @@ else if (flinkRoot != null) {
                FiniteDuration lookupTimeout = AkkaUtils.getTimeout(config);
     
                retriever = new JobManagerArchiveRetriever(this, actorSystem, 
lookupTimeout, timeout);
    -           
    +
                ExecutionGraphHolder currentGraphs = new 
ExecutionGraphHolder(retriever);
     
                router = new Router()
                        // config how to interact with this web server
    -                   .GET("/config", handler(new 
DashboardConfigHandler(cfg.getRefreshInterval())))
    +                   .GET("/config", handler(new 
DashboardConfigHandler(cfg.getRefreshInterval()), retriever))
     
                        // the overview - how many task managers, slots, free 
slots, ...
    -                   .GET("/overview", handler(new 
ClusterOverviewHandler(retriever, DEFAULT_REQUEST_TIMEOUT)))
    +                   .GET("/overview", handler(new 
ClusterOverviewHandler(retriever, DEFAULT_REQUEST_TIMEOUT), retriever))
     
                        // job manager configuration
    -                   .GET("/jobmanager/config", handler(new 
JobManagerConfigHandler(config)))
    +                   .GET("/jobmanager/config", handler(new 
JobManagerConfigHandler(config), retriever))
     
                        // overview over jobs
    -                   .GET("/joboverview", handler(new 
CurrentJobsOverviewHandler(retriever, DEFAULT_REQUEST_TIMEOUT, true, true)))
    -                   .GET("/joboverview/running", handler(new 
CurrentJobsOverviewHandler(retriever, DEFAULT_REQUEST_TIMEOUT, true, false)))
    -                   .GET("/joboverview/completed", handler(new 
CurrentJobsOverviewHandler(retriever, DEFAULT_REQUEST_TIMEOUT, false, true)))
    +                   .GET("/joboverview", handler(new 
CurrentJobsOverviewHandler(retriever, DEFAULT_REQUEST_TIMEOUT, true, true), 
retriever))
    --- End diff --
    
    Start the `RequestHandler` with the JobManager address of the local 
JobManager. They will only be called from the `RuntimeMonitorHandler` if the 
local JM is the leader.


> Redirect to leading JobManager web fronted in non-standalone mode
> -----------------------------------------------------------------
>
>                 Key: FLINK-2793
>                 URL: https://issues.apache.org/jira/browse/FLINK-2793
>             Project: Flink
>          Issue Type: Improvement
>          Components: JobManager
>    Affects Versions: 1.0
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>
> In case of a non-standalone recovery mode, the job manager frontend of 
> non-leading job managers prints the job manager information of its associated 
> job manager. Because the job manager is not leading, nothing shows up.
> The web frontend cannot directly communicate with the leading job manager, 
> because many job manager structures like the execution graph are not 
> serializable.
> A work around is to redirect to the web frontend of the leading job manager. 
> This makes sure that all interesting information is presented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to