tillrohrmann commented on a change in pull request #9609:
[FLINK-13750][client][coordination] Separate HA services between client-side
and server-side
URL: https://github.com/apache/flink/pull/9609#discussion_r320665694
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/MiniClusterClient.java
##########
@@ -51,14 +51,13 @@
private final MiniCluster miniCluster;
public MiniClusterClient(@Nonnull Configuration configuration, @Nonnull
MiniCluster miniCluster) {
- super(configuration, miniCluster.getHighAvailabilityServices(),
true);
-
+ super(configuration);
this.miniCluster = miniCluster;
}
@Override
public void shutdown() throws Exception {
- super.shutdown();
+ // no op
Review comment:
If there is a base implementation, then we don't need the no op override
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
