tillrohrmann commented on a change in pull request #9609:
[FLINK-13750][client][coordination] Separate HA services between client-side
and server-side
URL: https://github.com/apache/flink/pull/9609#discussion_r320676746
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
##########
@@ -142,6 +149,33 @@ private static File resolveFileLocation(String
logFilePath) {
}
}
+ /**
+ * Get address of web monitor from configuration.
+ *
+ * @param configuration Configuration contains those for WebMonitor.
+ * @param resolution Whether to try address resolution of the given
hostname or not.
+ * This allows to fail fast in case that the hostname
cannot be resolved.
+ * @return Address of WebMonitor.
+ */
+ public static String getWebMonitorAddress(
Review comment:
I'd rather put this method into the `HighAvailabilityServicesUtils` class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services