tillrohrmann commented on a change in pull request #9609:
[FLINK-13750][client][coordination] Separate HA services between client-side
and server-side
URL: https://github.com/apache/flink/pull/9609#discussion_r320709782
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/highavailability/HighAvailabilityServicesUtilsTest.java
##########
@@ -59,6 +59,22 @@ public void testCreateCustomHAServices() throws Exception {
assertSame(haServices, actualHaServices);
}
+ @Test
+ public void testCreateCustomClientHAServices() throws Exception {
+ Configuration config = new Configuration();
+
+ ClientHighAvailabilityServices clientHAServices =
Mockito.mock(ClientHighAvailabilityServices.class);
Review comment:
I know that this test class already uses `Mockito`. But I would like to
avoid adding more Mockito mocks. Instead we could have a very simple
`TestingClientHighAvailabilityServices` implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
