pnowojski commented on a change in pull request #9853: 
[FLINK-13904][checkpointing] Avoid competition of checkpoint triggering
URL: https://github.com/apache/flink/pull/9853#discussion_r335409965
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/utils/SimpleAckingTaskManagerGateway.java
 ##########
 @@ -70,6 +73,10 @@ public void setReleasePartitionsConsumer(BiConsumer<JobID, 
Collection<ResultPart
                this.releasePartitionsConsumer = releasePartitionsConsumer;
        }
 
+       public void setCheckpointConsumer(Consumer<Tuple6<ExecutionAttemptID, 
JobID, Long, Long, CheckpointOptions, Boolean>> checkpointConsumer) {
 
 Review comment:
   I can not find the usages of this code (introduced in the 
`[FLINK-13904][tests] Support checkpoint consumer of 
SimpleAckingTaskManagerGateway` commit). Am I missing something? Is it being 
used in a later PR (if so, can you move it to the correct PR)? Or is it some 
unused leftover?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to