pnowojski commented on a change in pull request #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#discussion_r335022275
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorRestoringTest.java ########## @@ -301,7 +310,7 @@ private void testRestoreLatestCheckpointIsPreferSavepoint(boolean isPreferCheckp failureManager); //trigger a checkpoint and wait to become a completed checkpoint - assertTrue(coord.triggerCheckpoint(timestamp, false)); + assertFalse(coord.triggerCheckpoint(timestamp, false).isCompletedExceptionally()); Review comment: If you replaced that with `coord.triggerCheckpoint(timestamp, false).get()`, would you still need the `checkpointTriggeredLatch`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services