pnowojski commented on a change in pull request #9853:
[FLINK-13904][checkpointing] Avoid competition of checkpoint triggering
URL: https://github.com/apache/flink/pull/9853#discussion_r335020372
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorMasterHooksTest.java
##########
@@ -201,7 +201,7 @@ public void testHooksAreCalledOnTrigger() throws Exception
{
cc.addMasterHook(statefulHook2);
// trigger a checkpoint
- assertTrue(cc.triggerCheckpoint(System.currentTimeMillis(),
false));
+ assertFalse(cc.triggerCheckpoint(System.currentTimeMillis(),
false).isCompletedExceptionally());
Review comment:
Shouldn't we wait for the future to complete? (and ditto in other places?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
