GJL commented on a change in pull request #9778: [FLINK-14206][runtime] Let
fullRestart metric count both full restarts and fine grained restarts
URL: https://github.com/apache/flink/pull/9778#discussion_r336055383
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
##########
@@ -690,7 +683,7 @@ public void
testRestartWithSlotSharingAndNotEnoughResources() throws Exception {
eg.scheduleForExecution();
// wait until no more changes happen
- while (eg.getNumberOfFullRestarts() < numRestarts) {
Review comment:
Originally, I got confused by the while loop:
```
while (eg.getNumberOfRestarts() < numRestarts) {
Thread.sleep(1);
Thread.sleep(1);
}
}
```
I was under the assumption that after calling `eg.scheduleForExecution()`
there is a separate thread updating the number of restarts in the background,
which is not the case. I think we can ditch the `while` loop or replace it with
an assertion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
