GJL commented on a change in pull request #9778: [FLINK-14206][runtime] Let 
fullRestart metric count both full restarts and fine grained restarts
URL: https://github.com/apache/flink/pull/9778#discussion_r336477207
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
 ##########
 @@ -595,9 +594,6 @@ public void 
slotPoolExecutionGraph_ConcurrentSchedulingAndAllocationFailure_Shou
 
        @Test
        public void testRestartWithEagerSchedulingAndSlotSharing() throws 
Exception {
-               // this test is inconclusive if not used with a proper 
multi-threaded executor
 
 Review comment:
   ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to