GJL commented on a change in pull request #9778: [FLINK-14206][runtime] Let 
fullRestart metric count both full restarts and fine grained restarts
URL: https://github.com/apache/flink/pull/9778#discussion_r336476569
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
 ##########
 @@ -264,6 +266,9 @@
        @Nullable
        private InternalTaskFailuresListener internalTaskFailuresListener;
 
+       /** Counts all restarts. Used by other Gauges/Meters and does not 
register to metric group. */
+       private final Counter numberOfRestartsCounter = new SimpleCounter();
 
 Review comment:
   Ok, it doesn't hurt to use a counter. However, I think that the counter can 
be maintained in the scheduler in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to