xintongsong commented on a change in pull request #9928: [FLINK-12122] Add 
support for spreading slots out across all TaskExecutors
URL: https://github.com/apache/flink/pull/9928#discussion_r336403845
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/configuration/ClusterOptions.java
 ##########
 @@ -50,4 +53,13 @@
                .key("cluster.services.shutdown-timeout")
                .defaultValue(30000L)
                .withDescription("The shutdown timeout for cluster services 
like executors in milliseconds.");
+
+       public static final ConfigOption<Boolean> 
EVENLY_SPREAD_OUT_SLOTS_STRATEGY = ConfigOptions
 
 Review comment:
   I'm not sure about exposing this option to the users.
   It seems to me that we can simply make 
`LeastUtilizationSlotMatchingStrategy` the default for standalone clusters, but 
keeps using `AnyMatchingSlotMatchingStrategy` for active mode clusters.
   I would try to avoid making this commitment to the users by exposing the 
option if possible. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to