xintongsong commented on a change in pull request #9928: [FLINK-12122] Add
support for spreading slots out across all TaskExecutors
URL: https://github.com/apache/flink/pull/9928#discussion_r336421508
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java
##########
@@ -575,8 +576,11 @@ public boolean releaseTaskManager(ResourceID resourceId,
Exception cause) {
@Nonnull
@Override
- public Collection<SlotInfo> getAvailableSlotsInformation() {
- final Collection<SlotInfo> allSlotInfos =
registeredSlots.values().stream().flatMap(Collection::stream).collect(Collectors.toList());
+ public Collection<SlotInfoWithUtilization>
getAvailableSlotsInformation() {
+ final Collection<SlotInfoWithUtilization> allSlotInfos
= registeredSlots.values().stream()
+ .flatMap(Collection::stream)
+ .map(slot -> SlotInfoWithUtilization.from(slot,
0))
+ .collect(Collectors.toList());
Review comment:
This change should be in the previous commit ("Calculate
TaskExecutorUtilization when listing available slots"), otherwise the previous
commit does not build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
