xintongsong commented on a change in pull request #9928: [FLINK-12122] Add
support for spreading slots out across all TaskExecutors
URL: https://github.com/apache/flink/pull/9928#discussion_r336424431
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/LocationPreferenceSlotSelectionStrategy.java
##########
@@ -64,19 +57,6 @@
selectWitLocationPreference(availableSlots,
locationPreferences, resourceProfile);
}
- @Nonnull
- private Optional<SlotInfoAndLocality> selectWithoutLocationPreference(
- @Nonnull Collection<SlotInfoAndResources> availableSlots,
- @Nonnull ResourceProfile resourceProfile) {
-
- for (SlotInfoAndResources candidate : availableSlots) {
- if
(candidate.getRemainingResources().isMatching(resourceProfile)) {
- return
Optional.of(SlotInfoAndLocality.of(candidate.getSlotInfo(),
Locality.UNCONSTRAINED));
- }
- }
- return Optional.empty();
- }
-
@Nonnull
private Optional<SlotInfoAndLocality> selectWitLocationPreference(
Review comment:
Typo in method name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
