xuefuz commented on a change in pull request #9937: [FLINK-14416][table] Add
Module interface and ModuleManager
URL: https://github.com/apache/flink/pull/9937#discussion_r336708888
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -118,7 +125,8 @@ public static TableEnvironmentImpl
create(EnvironmentSettings settings) {
settings.getBuiltInCatalogName(),
new
GenericInMemoryCatalog(settings.getBuiltInCatalogName(),
settings.getBuiltInDatabaseName()));
- FunctionCatalog functionCatalog = new
FunctionCatalog(catalogManager);
+ ModuleManager moduleManager = new ModuleManager();
Review comment:
Shouldn't we use the instance passed from the constructor instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
