zhuzhurk commented on a change in pull request #9936: [FLINK-14450][runtime]
Change SchedulingTopology to extend base topology
URL: https://github.com/apache/flink/pull/9936#discussion_r337613294
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/InputDependencyConstraintChecker.java
##########
@@ -44,9 +45,9 @@
private final SchedulingIntermediateDataSetManager
intermediateDataSetManager =
new SchedulingIntermediateDataSetManager();
- public boolean check(final SchedulingExecutionVertex
schedulingExecutionVertex) {
+ public boolean check(final SchedulingExecutionVertex<?, ?>
schedulingExecutionVertex) {
final InputDependencyConstraint inputConstraint =
schedulingExecutionVertex.getInputDependencyConstraint();
- if
(schedulingExecutionVertex.getConsumedResultPartitions().isEmpty() ||
ALL.equals(inputConstraint)) {
+ if
(!schedulingExecutionVertex.getConsumedResults().iterator().hasNext() ||
ALL.equals(inputConstraint)) {
Review comment:
Good suggestion! done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
