zhuzhurk commented on a change in pull request #9936: [FLINK-14450][runtime]
Change SchedulingTopology to extend base topology
URL: https://github.com/apache/flink/pull/9936#discussion_r337674809
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -259,7 +259,7 @@
private PartitionReleaseStrategy partitionReleaseStrategy;
- private SchedulingTopology schedulingTopology;
+ private SchedulingTopology<?, ?> schedulingTopology;
Review comment:
Shall we open a ticket to remove the lazy attaching mechanism, and build
vertices and do `executionTopology`/`partitionReleaseStrategy` initialization
in `ExecutionGraph` constructor?
In this way, `executionTopology` can be final, so that we do not need a
`FailingSchedulingTopology` to ensure its assigned correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
