zhuzhurk commented on a change in pull request #9936: [FLINK-14450][runtime]
Change SchedulingTopology to extend base topology
URL: https://github.com/apache/flink/pull/9936#discussion_r337606076
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -259,7 +259,7 @@
private PartitionReleaseStrategy partitionReleaseStrategy;
- private SchedulingTopology schedulingTopology;
+ private SchedulingTopology<?, ?> schedulingTopology;
Review comment:
Do you mean to avoid the case that a lazy attaching did not happen?
If so, I'm thinking whether we can make vertex building in ExecutionGraph
ctor and drop the lazy attaching mechanism. In production, the vertex attaching
is only invoked right after the EG is created in ExecutionGraphBuilder. And
attaching vertices after a job starts scheduling seems to be an undefined
behavior currently which would not work properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
