tillrohrmann commented on a change in pull request #9960: [FLINK-14476] Extend
PartitionTracker to support promotions
URL: https://github.com/apache/flink/pull/9960#discussion_r339089350
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerImplTest.java
##########
@@ -213,7 +213,7 @@ public void testReleaseCallsWithoutLocalResources() {
public void testStopTrackingIssuesNoReleaseCalls() {
final TestingShuffleMaster shuffleMaster = new
TestingShuffleMaster();
- final Queue<Tuple3<ResourceID, JobID,
Collection<ResultPartitionID>>> taskExecutorReleaseCalls = new
ArrayBlockingQueue<>(4);
+ final Queue<Tuple4<ResourceID, JobID,
Collection<ResultPartitionID>, Collection<ResultPartitionID>>>
taskExecutorReleaseCalls = new ArrayBlockingQueue<>(4);
Review comment:
I know that this is a testing class but I would usually try to avoid tuples.
Especially when the get more fields, they usually become quite hard to handle.
I think it is better to create a simple container class with properly named
fields. This also allows to add more fields without touching the usage sites.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
