tillrohrmann commented on a change in pull request #9960: [FLINK-14476] Extend
PartitionTracker to support promotions
URL: https://github.com/apache/flink/pull/9960#discussion_r340552855
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerImpl.java
##########
@@ -123,6 +120,22 @@ public void
stopTrackingAndReleasePartitionsFor(ResourceID producingTaskExecutor
stopTrackingAndReleasePartitions(resultPartitionIds);
}
+ @Override
+ public void stopTrackingAndReleaseOrPromotePartitionsFor(ResourceID
producingTaskExecutorId) {
+ Preconditions.checkNotNull(producingTaskExecutorId);
+
+ // this is a bit icky since we make 2 calls to
pT#stopTrackingPartitions
Review comment:
One thing one could easily improve is to give the `partitionTable` a `get`
method with which on resolves `ResourceID -> Collection<ResultPartitionID>`.
Then one would have a single place where one stops tracking the partitions
which would be `internalStopTrackingPartition`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
