tillrohrmann commented on a change in pull request #9960: [FLINK-14476] Extend
PartitionTracker to support promotions
URL: https://github.com/apache/flink/pull/9960#discussion_r339082309
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PartitionTrackerImpl.java
##########
@@ -102,7 +102,7 @@ public void
stopTrackingAndReleasePartitions(Collection<ResultPartitionID> resul
partitionMetaData ->
partitionMetaData.resultPartitionDeploymentDescriptor,
toList())));
-
partitionsToReleaseByResourceId.forEach(this::internalReleasePartitions);
+
partitionsToReleaseByResourceId.forEach(this::internalReleaseOrPromotePartitions);
Review comment:
I would expect that we don't promote partitions if the user calls
`PartitionTracker#stopTrackingAndReleasePartitions`. I guess we should also
release persistent result partitions here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
