bowenli86 commented on a change in pull request #9979: [FLINK-14417][table]
Develop CoreModule to provide Flink built-in functions
URL: https://github.com/apache/flink/pull/9979#discussion_r339156412
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleManager.java
##########
@@ -109,7 +109,7 @@ public void unloadModule(String name) throws
ModuleNotFoundException {
*/
public Optional<FunctionDefinition> getFunctionDefinition(String name) {
Optional<Module> module = modules.values().stream()
- .filter(p -> p.listFunctions().stream().anyMatch(e ->
e.equals(name)))
+ .filter(p -> p.listFunctions().stream().anyMatch(e ->
e.equalsIgnoreCase(name)))
Review comment:
You're spot on. That's something I'm considering. Right now we don't enforce
module function names to be case insensitive from Module interface, we may need
to document that in the API and add corresponding tests. We'll have a better
idea when core and hive module are both in place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
