zentol commented on a change in pull request #10034: [FLINK-14400] Shrink scope
of MemoryManager from TaskExecutor to slot
URL: https://github.com/apache/flink/pull/10034#discussion_r340700349
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
##########
@@ -115,6 +116,8 @@ public TaskManagerServicesConfiguration(
this.maxJvmHeapMemory = maxJvmHeapMemory;
this.localRecoveryEnabled = checkNotNull(localRecoveryEnabled);
this.queryableStateConfig = queryableStateConfig;
+
+ Preconditions.checkArgument(0 < numberOfSlots, "The number of
task slots must be greater than 0.");
Review comment:
The commit message says the check was `moved`, but this is just one more
check.
Also the null check below doesn't make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
