zentol commented on a change in pull request #10034: [FLINK-14400] Shrink scope
of MemoryManager from TaskExecutor to slot
URL: https://github.com/apache/flink/pull/10034#discussion_r340701721
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java
##########
@@ -89,6 +89,18 @@
/** Flag whether the close() has already been invoked. */
private volatile boolean isShutDown;
+ /**
+ * Creates a memory manager with the given memory types, capacity and
given page size.
+ *
+ * @param memorySizeByType The total size of the memory to be managed
by this memory manager for each type (heap / off-heap).
+ * @param pageSize The size of the pages handed out by the memory
manager.
+ */
+ public MemoryManager(
Review comment:
is github messing up the commit order again? to me it shows that the
numberOfSlots argument is removed in a prior commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
