zentol commented on a change in pull request #10034: [FLINK-14400] Shrink scope of MemoryManager from TaskExecutor to slot URL: https://github.com/apache/flink/pull/10034#discussion_r341058561
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTableBuilder.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.taskexecutor.slot; + +import org.apache.flink.api.common.time.Time; +import org.apache.flink.runtime.clusterframework.types.AllocationID; +import org.apache.flink.runtime.clusterframework.types.ResourceProfile; +import org.apache.flink.runtime.memory.MemoryManager; +import org.apache.flink.runtime.taskexecutor.TaskManagerServices; +import org.apache.flink.runtime.testingUtils.TestingUtils; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; + +/** Builder for {@link TaskSlotTable}. */ +public class TaskSlotTableBuilder { + private static final long DEFAULT_SLOT_TIMEOUT = 10000L; + + private static final ResourceProfile DEFAULT_RESOURCE_PROFILE = + TaskManagerServices.computeSlotResourceProfile(1, 10 * MemoryManager.MIN_PAGE_SIZE); + + private List<ResourceProfile> taskSlots; + private TimerService<AllocationID> timerService; + + private TaskSlotTableBuilder setTaskSlots(List<ResourceProfile> taskSlots) { + this.taskSlots = new ArrayList<>(taskSlots); + return this; + } + + public TaskSlotTableBuilder setTimerService(TimerService<AllocationID> timerService) { + this.timerService = timerService; + return this; + } + + public TaskSlotTableBuilder withTimerServiceTimeout(Time timeout) { + this.timerService = new TimerService<>(TestingUtils.defaultExecutor(), timeout.toMilliseconds()); Review comment: I'd rather have a dedicated factory method for creating such a timer service outside of this class which is then passed to the setter. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
