[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963955#comment-16963955
]
Jingsong Lee commented on FLINK-13702:
--------------------------------------
> There is one problem with entirely removing the serializer from
>{{BinaryGeneric that we can not implement equals/hashCode}} as they require
>that both objects have the same representation available.
Now consider JoinedRow, it can not equals and hashcode too, because we don't
know what row is below and how to serialize it to be consistent. (the values
serialized by GenericRow and BinaryRow are different)
> If we want to support {{LazyBinaryFormat}} for {{BinaryMap}} and
>{{BinaryArray}} in the future, considering the BinaryGeneric is nested in
>BinaryMap, I think we still need the {{materialize()}} method on
>{{BinaryGeneric}}. Which mean, we can't remove serializer from BinaryGeneric
>entirely.
About the implementation of future BinaryMap, we need serializer to do these
things, we have nested row, nested generic, it is necessary to do these
conversion by serializer. So I think there is no need to keep {{materialize().}}
> BaseMapSerializerTest.testDuplicate fails on Travis
> ---------------------------------------------------
>
> Key: FLINK-13702
> URL: https://issues.apache.org/jira/browse/FLINK-13702
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
> Affects Versions: 1.10.0
> Reporter: Till Rohrmann
> Assignee: Dawid Wysakowicz
> Priority: Critical
> Labels: test-stability
>
> The {{BaseMapSerializerTest.testDuplicate}} fails on Travis with an
> {{java.lang.IndexOutOfBoundsException}}.
> https://api.travis-ci.org/v3/job/570973199/log.txt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
