[ 
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964662#comment-16964662
 ] 

Jingsong Lee commented on FLINK-13702:
--------------------------------------

Hi [~dwysakowicz] [~jark], Let me summarize the current conclusions:

For BinaryLazyFormat: the core issue is we need it read-only thread safe on 
lazy initialization. Consider our binary segments are idempotent, _*we 
introduce a Binary class to wrap segments and offset and sizeInBytes*_,  to let 
the lazy field be a single field, In this way, even if different threads 
initialize different instances, there will be no conflict. It will become a 
read-only thread-safe lazy initialization.

For BinaryGeneric: *_We need get it rid of serializer, equals and hashcode 
should throw unsupport exception_.* One implementation way is push down methods 
to BinaryString from LazyBinaryFormat,  in this way, BinaryString and 
BinaryGeneric have different methods, methods of BinaryGeneric should have 
serializer argument.

Correct me if I am wrong.

> BaseMapSerializerTest.testDuplicate fails on Travis
> ---------------------------------------------------
>
>                 Key: FLINK-13702
>                 URL: https://issues.apache.org/jira/browse/FLINK-13702
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>    Affects Versions: 1.10.0
>            Reporter: Till Rohrmann
>            Assignee: Dawid Wysakowicz
>            Priority: Critical
>              Labels: test-stability
>
> The {{BaseMapSerializerTest.testDuplicate}} fails on Travis with an 
> {{java.lang.IndexOutOfBoundsException}}.
> https://api.travis-ci.org/v3/job/570973199/log.txt



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to