AHeise commented on a change in pull request #10009: [FLINK-14304] Avoid task
starvation with mailbox
URL: https://github.com/apache/flink/pull/10009#discussion_r342595260
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImplTest.java
##########
@@ -156,26 +156,26 @@ public void testLifeCycleClose() throws Exception {
try {
taskMailbox.take(DEFAULT_PRIORITY);
Assert.fail();
- } catch (MailboxStateException ignore) {
+ } catch (IllegalStateException ignore) {
Review comment:
I'd leave it as is. ExpectedException would work if we only check for one
but there are many exceptions where two occur.
I will introduce
[assertj](https://joel-costigliola.github.io/assertj/assertj-core-features-highlight.html#exception-assertion)
soonish and then we can express that much more beautifully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
