AHeise commented on a change in pull request #10009: [FLINK-14304] Avoid task
starvation with mailbox
URL: https://github.com/apache/flink/pull/10009#discussion_r343334521
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImpl.java
##########
@@ -77,22 +112,30 @@ public boolean hasMail() {
@Override
public Optional<Mail> tryTake(int priority) throws
IllegalStateException {
+ Optional<Mail> head = tryTakeFromBatch();
Review comment:
Clarified the contract in `TaskMailbox`. And added a test based on the
stream task test harness that checks that only mails in the current batch are
taken. Also added more comment to the unit tests that tests the interaction on
a fine-grain level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
