AHeise commented on a change in pull request #10009: [FLINK-14304] Avoid task 
starvation with mailbox
URL: https://github.com/apache/flink/pull/10009#discussion_r342704114
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImpl.java
 ##########
 @@ -211,26 +215,27 @@ private void checkTakeStateConditions() {
 
        @Override
        public void quiesce() {
+               final ReentrantLock lock = this.lock;
 
 Review comment:
   I did a small JMS benchmark. I saw a 1% degrade when removing local 
variables. But that could be well within measure error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to