zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r342966862
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureSampleCoordinator.java
##########
@@ -156,46 +154,43 @@ public StackTraceSampleCoordinator(Executor executor,
long sampleTimeout) {
// Trigger all samples
for (Execution execution: executions) {
- final
CompletableFuture<StackTraceSampleResponse> stackTraceSampleFuture =
execution.requestStackTraceSample(
- sampleId,
- numSamples,
- delayBetweenSamples,
- maxStackTraceDepth,
- timeout);
-
- stackTraceSampleFuture.handleAsync(
- (StackTraceSampleResponse
stackTraceSampleResponse, Throwable throwable) -> {
- if (stackTraceSampleResponse !=
null) {
- collectStackTraces(
-
stackTraceSampleResponse.getSampleId(),
-
stackTraceSampleResponse.getExecutionAttemptID(),
-
stackTraceSampleResponse.getSamples());
+ final
CompletableFuture<TaskBackPressureSampleResponse> taskBackPressureFuture =
+
execution.sampleTaskBackPressure(sampleId, numSamples, delayBetweenSamples,
timeout);
+
+ taskBackPressureFuture.handleAsync(
+ (TaskBackPressureSampleResponse
taskBackPressureSampleResponse, Throwable throwable) -> {
+ if
(taskBackPressureSampleResponse != null) {
+
collectTaskBackPressureStat(
Review comment:
`collectTaskBackPressureStat` -> `collectTaskBackPressureSample`. It is
better to unify some terms here.
E.g. `cancelTaskBackPressureSample`, `collectTaskBackPressureSample`,
`TaskBackPressureSampleResponse`
Also for the below class `PendingTaskBackPressureStats` ->
`PendingTaskBackPressureSample`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
