zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r342974206
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureStatsTrackerImpl.java
##########
@@ -296,21 +240,21 @@ public Void apply(StackTraceSample stackTraceSample,
Throwable throwable) {
}
/**
- * Creates the back pressure stats from a stack trace sample.
+ * Creates operator back pressure stats from task back pressure
stats.
*
- * @param sample Stack trace sample to base stats on.
+ * @param stats Task back pressure stats.
*
- * @return Back pressure stats
+ * @return Operator back pressure stats
*/
- private OperatorBackPressureStats
createStatsFromSample(StackTraceSample sample) {
- Map<ExecutionAttemptID, List<StackTraceElement[]>>
traces = sample.getStackTraces();
+ private OperatorBackPressureStats
createOperatorBackPressureStats(BackPressureStats stats) {
Review comment:
TBH I do not like the class naming `OperatorBackPressureStats`, because when
compared with `BackPressureStats` class it is not the task/operator level
difference. Actually they are indicating the same level, only transforming the
map from `BackPressureStats` to array in `OperatorBackPressureStats`.
Since we have not touched the class `OperatorBackPressureStats` in this PR,
so we can keep it as now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
