zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r342956700
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -925,33 +925,30 @@ public void fail(Throwable t) {
}
/**
- * Request a stack trace sample from the task of this execution.
+ * Request to sample the back pressure ratio from the task of this
execution.
*
- * @param sampleId of the stack trace sample
- * @param numSamples the sample should contain
- * @param delayBetweenSamples to wait
- * @param maxStackTraceDepth of the samples
- * @param timeout until the request times out
- * @return Future stack trace sample response
+ * @param sampleId id of the sample
+ * @param numSamples the number of samples to take
+ * @param delayBetweenSamples time to wait between samples
+ * @param timeout the request times out
+ * @return Future containing the task back pressure sampling results
*/
- public CompletableFuture<StackTraceSampleResponse>
requestStackTraceSample(
+ public CompletableFuture<TaskBackPressureSampleResponse>
sampleTaskBackPressure(
Review comment:
nit : sampleTaskBackPressure -> requestTaskBackPressure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
