zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r342969795
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureStats.java
##########
@@ -21,44 +21,43 @@
import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
import java.util.Collections;
-import java.util.List;
import java.util.Map;
import static org.apache.flink.util.Preconditions.checkArgument;
/**
- * A sample of stack traces for one or more tasks.
+ * Task back pressure stats for one or more tasks.
*
- * <p>The sampling is triggered in {@link StackTraceSampleCoordinator}.
+ * <p>The stats are calculated from sampling triggered in {@link
BackPressureSampleCoordinator}.
*/
-public class StackTraceSample {
+public class BackPressureStats {
- /** ID of this sample (unique per job). */
+ /** ID of the sample (unique per job). */
private final int sampleId;
/** Time stamp, when the sample was triggered. */
private final long startTime;
- /** Time stamp, when all stack traces were collected at the JobManager.
*/
+ /** Time stamp, when all back pressure stats were collected at the
JobManager. */
private final long endTime;
- /** Map of stack traces by execution ID. */
- private final Map<ExecutionAttemptID, List<StackTraceElement[]>>
stackTracesByTask;
+ /** Map of back pressure ratio by execution ID. */
+ private final Map<ExecutionAttemptID, Double> backPressureRatioByTask;
Review comment:
`backPressureRatioByTask` -> `backPressureRatiosByTask` or
`backPressureRatios`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
