zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r343044791
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/TestingJobManagerSharedServicesBuilder.java
##########
@@ -54,7 +54,7 @@ public TestingJobManagerSharedServicesBuilder() {
scheduledExecutorService = TestingUtils.defaultExecutor();
libraryCacheManager =
ContextClassLoaderLibraryCacheManager.INSTANCE;
restartStrategyFactory = new
NoOrFixedIfCheckpointingEnabledRestartStrategyFactory();
- stackTraceSampleCoordinator =
mock(StackTraceSampleCoordinator.class);
+ backPressureSampleCoordinator =
mock(BackPressureSampleCoordinator.class);
Review comment:
It is better not to mock class here. Since we already touched this class
change, then it should be properly used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
