danny0405 commented on a change in pull request #10098:
[FLINK-14326][FLINK-14324][table] Support to apply watermark assigner in planner
URL: https://github.com/apache/flink/pull/10098#discussion_r343059473
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/PhysicalTableSourceScan.scala
##########
@@ -58,7 +58,13 @@ abstract class PhysicalTableSourceScan(
}
override def explainTerms(pw: RelWriter): RelWriter = {
- super.explainTerms(pw).item("fields",
getRowType.getFieldNames.asScala.mkString(", "))
+ val hasWatermark = tableSourceTable.watermarkSpec.isDefined &&
tableSourceTable.isStreamingMode
+ val rowtime =
tableSourceTable.watermarkSpec.map(_.getRowtimeAttribute).orNull
Review comment:
Does this mean batch mode may also have watermark definitions ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services