danny0405 commented on a change in pull request #10098:
[FLINK-14326][FLINK-14324][table] Support to apply watermark assigner in planner
URL: https://github.com/apache/flink/pull/10098#discussion_r343064275
##########
File path:
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/sqlexec/SqlToOperationConverterTest.java
##########
@@ -187,6 +192,45 @@ public void testCreateTableWithMinusInOptionKey() {
assertEquals(expected, sortedProperties.toString());
}
+ @Test
+ public void testCreateTableWithWatermark() throws
FunctionAlreadyExistException, DatabaseNotExistException {
+ CatalogFunction cf = new CatalogFunctionImpl(
+
JavaUserDefinedScalarFunctions.JavaFunc5.class.getName(),
Review comment:
Use `functionCatalog.registerTempSystemScalarFunction(` is ok, there is no
need to create define a new function `JavaFunc5`. You can pick a function in
`org.apache.flink.table.planner.expressions.utils.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
