danny0405 commented on a change in pull request #10098:
[FLINK-14326][FLINK-14324][table] Support to apply watermark assigner in planner
URL: https://github.com/apache/flink/pull/10098#discussion_r343053601
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/delegation/PlannerContext.java
##########
@@ -151,6 +154,17 @@ public FlinkPlannerImpl createFlinkPlanner(String
currentCatalog, String current
cluster);
}
+ /**
+ * Creates a new instance of [[SqlToRexConverter]] to convert SQL
expression to RexNode.
+ */
+ public SqlToRexConverter createSqlToRexConverter(RelDataType
tableRowType) {
+ return new SqlToRexConverterImpl(
+ createFrameworkConfig(),
Review comment:
I don't think `createSqlToRexConverter` belongs to `PlannerContext`, the
main usage of `PlannerContext` is to create `FlinkPlannerImpl`(the class name
already indicates that). Maybe we can move it into `FlinkPlannerImpl`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
