danny0405 commented on a change in pull request #10123: 
[FLINK-14665][table-planner-blink] Support computed column for create…
URL: https://github.com/apache/flink/pull/10123#discussion_r344436277
 
 

 ##########
 File path: 
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LegacyTypeInformationType.java
 ##########
 @@ -50,7 +50,14 @@
        private final TypeInformation<T> typeInfo;
 
        public LegacyTypeInformationType(LogicalTypeRoot logicalTypeRoot, 
TypeInformation<T> typeInfo) {
-               super(true, logicalTypeRoot);
+               this(true, logicalTypeRoot, typeInfo);
+       }
+
+       public LegacyTypeInformationType(
+                       boolean nullable,
 
 Review comment:
   To fix the nullability, this is not a TypeInformation, this is a 
LogicalType, see it's `#copy()` method how the nullability was used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to