danny0405 commented on a change in pull request #10123: 
[FLINK-14665][table-planner-blink] Support computed column for create…
URL: https://github.com/apache/flink/pull/10123#discussion_r344436701
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/schema/FlinkRelOptTable.scala
 ##########
 @@ -221,12 +230,40 @@ class FlinkRelOptTable protected(
     val cluster: RelOptCluster = context.getCluster
     if (table.isInstanceOf[TranslatableTable]) {
       table.asInstanceOf[TranslatableTable].toRel(context, this)
-    } else if (Hook.ENABLE_BINDABLE.get(false)) {
 
 Review comment:
   Because Flink never use it, the orgina `ENABLE_BINDABLE` is only used for 
Calcite bindables. The code is wrong.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to