danny0405 commented on a change in pull request #10123:
[FLINK-14665][table-planner-blink] Support computed column for create…
URL: https://github.com/apache/flink/pull/10123#discussion_r344437426
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/PhysicalTableSourceScan.scala
##########
@@ -53,8 +52,9 @@ abstract class PhysicalTableSourceScan(
protected[flink] val tableSource: TableSource[_] =
tableSourceTable.tableSource
override def deriveRowType(): RelDataType = {
- val flinkTypeFactory =
cluster.getTypeFactory.asInstanceOf[FlinkTypeFactory]
- tableSourceTable.getRowType(flinkTypeFactory)
+ // TableScan row type should always keep same with its
Review comment:
If the projection was pushed down, we should modify the relOptTable to keep
the row type same as the projected table source. Because the RelOptTable has
the ability to convert a table to relational expression, so we should keep it
equivalence node with the underlying relational expression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
