walterddr commented on a change in pull request #10143: [FLINK-13184]Starting a
TaskExecutor blocks the YarnResourceManager's main thread
URL: https://github.com/apache/flink/pull/10143#discussion_r344503126
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/BootstrapToolsTest.java
##########
@@ -159,18 +159,29 @@ public void testGetTaskManagerShellCommand() {
"-Dlog4j.configuration=file:./conf/log4j.properties";
// if set
final String mainClass =
"org.apache.flink.runtime.clusterframework.BootstrapToolsTest";
- final String args = "--configDir ./conf";
+ final String basicArgs = "--configDir ./conf";
+ final String mainArgs = "-Djobmanager.rpc.address=host1
-Dkey.a=v1";
+ final String args = basicArgs + " " + mainArgs;
final String redirects =
"1> ./logs/taskmanager.out 2> ./logs/taskmanager.err";
+ assertEquals(
+ java + " " + jvmmem +
+ " " + // jvmOpts
+ " " + // logging
Review comment:
judging by the placeholder, are we missing some test impl here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
