walterddr commented on a change in pull request #10143: [FLINK-13184]Starting a
TaskExecutor blocks the YarnResourceManager's main thread
URL: https://github.com/apache/flink/pull/10143#discussion_r345537627
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -844,14 +844,16 @@ private ApplicationReport startAppMaster(
tmpConfigurationFile.deleteOnExit();
BootstrapTools.writeConfiguration(configuration,
tmpConfigurationFile);
+ String flinkConfigKey = "flink-conf.yaml";
Path remotePathConf = setupSingleLocalResource(
- "flink-conf.yaml",
+ flinkConfigKey,
fs,
appId,
new
Path(tmpConfigurationFile.getAbsolutePath()),
localResources,
homeDir,
"");
+
envShipFileList.append(flinkConfigKey).append("=").append(remotePathConf).append(",");
Review comment:
hmm. I second @TisonKun here - if we eventually have to put the
`flink-conf.yaml` into the envShipFileList . wouldn't we still eventually
upload the file into DFS (based on [this
comment](https://github.com/apache/flink/pull/10143/files#r344503690), I
thought this is the problem we were trying to avoid in the first place) ?
(@TisonKun please correct me if I understood you wrong)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
