KurtYoung commented on a change in pull request #10105:
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink
planner
URL: https://github.com/apache/flink/pull/10105#discussion_r344573331
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala
##########
@@ -174,8 +174,8 @@ object ScalarOperatorGens {
(l, r) => s"$l $op ((int) ($r / ${MILLIS_PER_DAY}L))"
}
case TIMESTAMP_WITHOUT_TIME_ZONE =>
- generateOperatorIfNotNull(ctx, new TimestampType(), left, right) {
- (l, r) => s"($l * ${MILLIS_PER_DAY}L) $op $r"
+ generateOperatorIfNotNull(ctx, new TimestampType(3), left, right) {
Review comment:
I'm not sure this is the right way to go. We either don't change it and
leave it to next issue, or we make it right in this PR. We don't encourage to
do some wrong modification and say you will fix it in following jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
