KurtYoung commented on a change in pull request #10105:
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink
planner
URL: https://github.com/apache/flink/pull/10105#discussion_r345595955
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala
##########
@@ -1073,51 +1124,51 @@ object ScalarOperatorGens {
(INTEGER, TIMESTAMP_WITHOUT_TIME_ZONE) |
(BIGINT, TIMESTAMP_WITHOUT_TIME_ZONE) =>
generateUnaryOperatorIfNotNull(ctx, targetType, operand) {
- operandTerm => s"(((long) $operandTerm) * 1000)"
+ operandTerm => s"$SQL_TIMESTAMP.fromEpochMillis(((long) $operandTerm)
* 1000)"
}
// Float -> Timestamp
// Double -> Timestamp
case (FLOAT, TIMESTAMP_WITHOUT_TIME_ZONE) |
(DOUBLE, TIMESTAMP_WITHOUT_TIME_ZONE) =>
generateUnaryOperatorIfNotNull(ctx, targetType, operand) {
- operandTerm => s"((long) ($operandTerm * 1000))"
+ operandTerm => s"$SQL_TIMESTAMP.fromEpochMillis((long) ($operandTerm *
1000))"
}
// Timestamp -> Tinyint
case (TIMESTAMP_WITHOUT_TIME_ZONE, TINYINT) =>
generateUnaryOperatorIfNotNull(ctx, targetType, operand) {
- operandTerm => s"((byte) ($operandTerm / 1000))"
+ operandTerm => s"((byte) ($operandTerm.getMillisecond() / 1000))"
}
// Timestamp -> Smallint
case (TIMESTAMP_WITHOUT_TIME_ZONE, SMALLINT) =>
generateUnaryOperatorIfNotNull(ctx, targetType, operand) {
- operandTerm => s"((short) ($operandTerm / 1000))"
+ operandTerm => s"((short) ($operandTerm.getMillisecond() / 1000))"
}
// Timestamp -> Int
case (TIMESTAMP_WITHOUT_TIME_ZONE, INTEGER) =>
generateUnaryOperatorIfNotNull(ctx, targetType, operand) {
- operandTerm => s"((int) ($operandTerm / 1000))"
+ operandTerm => s"((int) ($operandTerm.getMillisecond() / 1000))"
}
// Timestamp -> BigInt
case (TIMESTAMP_WITHOUT_TIME_ZONE, BIGINT) =>
generateUnaryOperatorIfNotNull(ctx, targetType, operand) {
- operandTerm => s"((long) ($operandTerm / 1000))"
+ operandTerm => s"((long) ($operandTerm.getMillisecond() / 1000))"
Review comment:
what do you think about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
