KurtYoung commented on a change in pull request #10105:
[Flink-14599][table-planner-blink] Support precision of TimestampType in blink
planner
URL: https://github.com/apache/flink/pull/10105#discussion_r345592288
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala
##########
@@ -334,8 +336,12 @@ class RexNodeToExpressionConverter(
LocalTimeConverter.INSTANCE.toExternal(v)
case TIMESTAMP_WITHOUT_TIME_ZONE =>
- val v = literal.getValueAs(classOf[java.lang.Long])
- LocalDateTimeConverter.INSTANCE.toExternal(v)
+ val timestampString = literal.getValueAs(classOf[TimestampString])
+ val millis =
SqlDateTimeUtils.getMillisSinceEpoch(timestampString.toString)
Review comment:
Reuse the result of `timestampString.toString`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
