pnowojski commented on a change in pull request #10084: [FLINK-14382][yarn]
Incorrect handling of FLINK_PLUGINS_DIR on Yarn
URL: https://github.com/apache/flink/pull/10084#discussion_r344685254
##########
File path:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java
##########
@@ -571,8 +622,15 @@ public ParameterTool mergeWith(ParameterTool other) {
// ------------------------- ExecutionConfig.UserConfig interface
-------------------------
@Override
+ /*
+ * The value collection has at least one value, do not need to check
null here.
+ * If there are multiple values, only the first one will be used.
+ */
public Map<String, String> toMap() {
- return data;
+ return data.entrySet().stream().collect(Collectors.toMap(
Review comment:
add `checkState(e.getValue().size() == 1)` and provide a `toMultiMap`
variant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
