pnowojski commented on a change in pull request #10084: [FLINK-14382][yarn]
Incorrect handling of FLINK_PLUGINS_DIR on Yarn
URL: https://github.com/apache/flink/pull/10084#discussion_r344743842
##########
File path:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java
##########
@@ -91,22 +94,23 @@ public static ParameterTool fromArgs(String[] args) {
i += 1; // try to find the value
+ map.putIfAbsent(key, new ArrayList<>());
Review comment:
I think by default we should preserve the old behaviour and add an
overloaded version of this method `ParameterTool#fromArgs(String[] args,
boolean multipleValues)` or something like that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
