pnowojski commented on a change in pull request #10084: [FLINK-14382][yarn]
Incorrect handling of FLINK_PLUGINS_DIR on Yarn
URL: https://github.com/apache/flink/pull/10084#discussion_r344743842
##########
File path:
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java
##########
@@ -91,22 +94,23 @@ public static ParameterTool fromArgs(String[] args) {
i += 1; // try to find the value
+ map.putIfAbsent(key, new ArrayList<>());
Review comment:
I think by default we should preserve the old behaviour and add an
overloaded version of this method `ParameterTool#fromArgs(String[] args,
boolean multipleValues)` or something like that?
edit: now that I'm looking at it, I didn't notice before that
`ParameterTool` is a `@Public` class, which is even [documented
](https://ci.apache.org/projects/flink/flink-docs-stable/dev/best_practices.html#getting-your-configuration-values-into-the-parametertool).
One issue is that we have to be extra careful not to change the semantic and
another, is that we if we want to modify `Public` api, we should think it
through more thoroughly.
Maybe a way to avoid this, is to provide `MultipleParameterTool`, marked as
`@PublicEvolving` or even `@Internal`, with some inheritance/composition to
deduplicate it with the existing `ParameterTool`? What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
